Put common header on metrics page#37
Merged
Merged
Conversation
The CSS in this file is only needed on the graph page. The only thing the other pages needed was to set the font, which is now achieved by using the "govuk-body" class provided by the GOV.UK Design System. Since this also means that the setting of the `main` element to use a grid style is only applied on the graph page, the wrapper `div` element is no longer needed on the graph unavailable page. It's kept on the visualisation list page so that the "govuk-body" class can be applied. An unused class "visualistion-list" has also been removed from the html.
This means all the pages are now extending the base template, and have the same header included.
rjsteixeira
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the metrics page to use the same base template as the other pages, inheriting the standard header.
To enable this involved tweaking the base template slightly to move the reference to the graph CSS file down into the graph page template.